Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1839133002: Ensure synchronized access to the perf dump file. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure synchronized access to the perf dump file. This CL introduces static variables and global lock for writing to the dump files, so that multiple web workers do not run into trouble. Committed: https://crrev.com/cfd3cd6b00032ac94430f939ebf79bab58a23e1e Cr-Commit-Position: refs/heads/master@{#35123}

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -11 lines) Patch
M src/perf-jit.h View 1 1 chunk +7 lines, -3 lines 0 comments Download
M src/perf-jit.cc View 1 4 chunks +31 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please?
4 years, 8 months ago (2016-03-29 20:55:23 UTC) #3
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-03-30 05:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839133002/20001
4 years, 8 months ago (2016-03-30 05:12:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 05:13:57 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 05:14:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cfd3cd6b00032ac94430f939ebf79bab58a23e1e
Cr-Commit-Position: refs/heads/master@{#35123}

Powered by Google App Engine
This is Rietveld 408576698