Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1839123004: Force include test to run on every compile. (Closed)

Created:
4 years, 8 months ago by djsollen
Modified:
4 years, 8 months ago
Reviewers:
bungeman-skia, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Force include test to run on every compile. Also fix the tool to stop looking in the src dir for includes. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1839123004 Committed: https://skia.googlesource.com/skia/+/7c9c4a775dcc3517f46b7734c86b29d93ec9be4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M gyp/tools.gyp View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
djsollen
4 years, 8 months ago (2016-03-30 15:06:09 UTC) #3
bsalomon
lgtm
4 years, 8 months ago (2016-03-30 15:08:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839123004/1
4 years, 8 months ago (2016-03-30 15:10:51 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 15:28:05 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7c9c4a775dcc3517f46b7734c86b29d93ec9be4a

Powered by Google App Engine
This is Rietveld 408576698