Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1839123003: Begin work on ios secure sockets (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 6

Patch Set 6 : Address comments #

Patch Set 7 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -757 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
M runtime/bin/io_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 2 3 4 5 6 1 chunk +10 lines, -8 lines 0 comments Download
A + runtime/bin/secure_socket_ios.cc View 1 2 3 4 5 6 14 chunks +26 lines, -744 lines 0 comments Download
M runtime/bin/secure_socket_macos.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/platform/globals.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/io/security_context.dart View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 8 months ago (2016-03-31 16:28:57 UTC) #2
Ivan Posva
LGTM with comments. -Ivan https://codereview.chromium.org/1839123003/diff/80001/runtime/bin/platform_macos.cc File runtime/bin/platform_macos.cc (right): https://codereview.chromium.org/1839123003/diff/80001/runtime/bin/platform_macos.cc#newcode79 runtime/bin/platform_macos.cc:79: // TODO(zra,chinmaygarde): On iOS, environment ...
4 years, 8 months ago (2016-03-31 17:27:53 UTC) #3
zra
Committed patchset #7 (id:120001) manually as 08450dc4324d9605d25a0997b6f1dfcc9501a053 (presubmit successful).
4 years, 8 months ago (2016-03-31 19:55:36 UTC) #5
zra
4 years, 8 months ago (2016-03-31 20:00:17 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1839123003/diff/80001/runtime/bin/platform_ma...
File runtime/bin/platform_macos.cc (right):

https://codereview.chromium.org/1839123003/diff/80001/runtime/bin/platform_ma...
runtime/bin/platform_macos.cc:79: // TODO(zra,chinmaygarde): On iOS, environment
varialbes are seldom used. Wire
On 2016/03/31 17:27:53, Ivan Posva wrote:
> variables

Done.

https://codereview.chromium.org/1839123003/diff/80001/runtime/bin/secure_sock...
File runtime/bin/secure_socket_ios.cc (right):

https://codereview.chromium.org/1839123003/diff/80001/runtime/bin/secure_sock...
runtime/bin/secure_socket_ios.cc:8: #if defined(TARGET_OS_MACOS) &&
defined(TARGET_OS_IOS)
On 2016/03/31 17:27:53, Ivan Posva wrote:
> This is a bit confusing. Why not just TARGET_OS_IOS?

Done.

https://codereview.chromium.org/1839123003/diff/80001/runtime/bin/secure_sock...
runtime/bin/secure_socket_ios.cc:437: "X509Certificate.issuer is not yet
implemented."));
On 2016/03/31 17:27:53, Ivan Posva wrote:
> What is the difference between "not yet implemented" and "not supported". Do
you
> plan to implement these calls?

I'm planning to implement the other 'not yet implemented' calls, but this one
should have been 'not supported'.

Powered by Google App Engine
This is Rietveld 408576698