Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1839083003: [Android] Switch instrumentation tests to platform mode. (RELAND 2) (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch instrumentation tests to platform mode. (RELAND 2) This is a reland of https://codereview.chromium.org/1836883002/ BUG=428729 TBR=yfriedman@chromium.org Committed: https://crrev.com/b71170d0d94d3d2c6d2feedc92bfc88906cff22f Cr-Commit-Position: refs/heads/master@{#383896}

Patch Set 1 #

Patch Set 2 : fixed: make --apk-under-test truly optional #

Patch Set 3 : fix # instrumentation test filters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M base/android/javatests/src/org/chromium/base/CommandLineInitUtilTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 2 4 chunks +17 lines, -11 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 2 chunks +11 lines, -10 lines 0 comments Download
M build/android/test_runner.py View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jbudorick
tested against MojoTest locally.
4 years, 8 months ago (2016-03-29 20:01:25 UTC) #2
rnephew (Reviews Here)
On 2016/03/29 20:01:25, jbudorick wrote: > tested against MojoTest locally. lgtm
4 years, 8 months ago (2016-03-29 20:09:06 UTC) #3
mikecase (-- gone --)
lgtm
4 years, 8 months ago (2016-03-29 20:18:33 UTC) #4
jbudorick
TBR yfriedman: base/android/ unchanged from https://codereview.chromium.org/1836883002/
4 years, 8 months ago (2016-03-29 20:21:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839083003/20001
4 years, 8 months ago (2016-03-29 20:22:47 UTC) #9
mikecase (-- gone --)
still lgtm w/ newest patch
4 years, 8 months ago (2016-03-30 00:02:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839083003/40001
4 years, 8 months ago (2016-03-30 00:03:49 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-30 01:32:17 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 01:33:08 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b71170d0d94d3d2c6d2feedc92bfc88906cff22f
Cr-Commit-Position: refs/heads/master@{#383896}

Powered by Google App Engine
This is Rietveld 408576698