Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 1839063005: Reland of move libpeerconnection target from third_party/libjingle (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move libpeerconnection target from third_party/libjingle (patchset #1 id:1 of https://codereview.chromium.org/1834163002/ ) Reason for revert: The config.h problem was addressed in https://codereview.webrtc.org/1820023004/ which was rolled in with https://codereview.chromium.org/1840133002/ Original issue's description: > Revert of Remove libpeerconnection target from third_party/libjingle (patchset #4 id:60001 of https://codereview.chromium.org/1808233002/ ) > > Reason for revert: > Broke clang/win gn build (https://bugs.chromium.org/p/chromium/issues/detail?id=598316), as mentioned in the review thread in comment 24. > > Original issue's description: > > Remove libpeerconnection target from third_party/libjingle > > > > All locations that depended on the target also depended on libjingle_webrtc, > > which is where the sources of libpeerconnection were moved. > > > > BUG=webrtc:4256, 481633 > > > > Committed: https://crrev.com/696e62e66c1f1d2121f1451501d3066bf2f5ea4f > > Cr-Commit-Position: refs/heads/master@{#383468} > > TBR=jochen@chromium.org,jam@chromium.org,sergeyu@chromium.org,tommi@chromium.org,kjellander@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:4256, 481633 > > Committed: https://crrev.com/8d484368f9d4013effeee0e078fbe7039254cd45 > Cr-Commit-Position: refs/heads/master@{#383490} TBR=jochen@chromium.org,jam@chromium.org,sergeyu@chromium.org,tommi@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:4256, 481633 Committed: https://crrev.com/fa750194a54e409ae0bf265a188c536e8c4f7e28 Cr-Commit-Position: refs/heads/master@{#383913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -80 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 4 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/host/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/BUILD.gn View 3 chunks +11 lines, -27 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 7 chunks +12 lines, -31 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kjellander_chromium
Created Reland of move libpeerconnection target from third_party/libjingle
4 years, 8 months ago (2016-03-29 19:16:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839063005/1
4 years, 8 months ago (2016-03-29 19:34:12 UTC) #3
kjellander_chromium
On 2016/03/29 19:34:12, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 8 months ago (2016-03-29 19:35:51 UTC) #4
tommi (sloooow) - chröme
lgtm
4 years, 8 months ago (2016-03-29 20:09:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 22:03:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839063005/1
4 years, 8 months ago (2016-03-30 05:32:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 05:38:50 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 05:40:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa750194a54e409ae0bf265a188c536e8c4f7e28
Cr-Commit-Position: refs/heads/master@{#383913}

Powered by Google App Engine
This is Rietveld 408576698