DescriptionReland of move libpeerconnection target from third_party/libjingle (patchset #1 id:1 of https://codereview.chromium.org/1834163002/ )
Reason for revert:
The config.h problem was addressed in https://codereview.webrtc.org/1820023004/ which was rolled in with https://codereview.chromium.org/1840133002/
Original issue's description:
> Revert of Remove libpeerconnection target from third_party/libjingle (patchset #4 id:60001 of https://codereview.chromium.org/1808233002/ )
>
> Reason for revert:
> Broke clang/win gn build (https://bugs.chromium.org/p/chromium/issues/detail?id=598316), as mentioned in the review thread in comment 24.
>
> Original issue's description:
> > Remove libpeerconnection target from third_party/libjingle
> >
> > All locations that depended on the target also depended on libjingle_webrtc,
> > which is where the sources of libpeerconnection were moved.
> >
> > BUG=webrtc:4256, 481633
> >
> > Committed: https://crrev.com/696e62e66c1f1d2121f1451501d3066bf2f5ea4f
> > Cr-Commit-Position: refs/heads/master@{#383468}
>
> TBR=jochen@chromium.org,jam@chromium.org,sergeyu@chromium.org,tommi@chromium.org,kjellander@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4256, 481633
>
> Committed: https://crrev.com/8d484368f9d4013effeee0e078fbe7039254cd45
> Cr-Commit-Position: refs/heads/master@{#383490}
TBR=jochen@chromium.org,jam@chromium.org,sergeyu@chromium.org,tommi@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:4256, 481633
Committed: https://crrev.com/fa750194a54e409ae0bf265a188c536e8c4f7e28
Cr-Commit-Position: refs/heads/master@{#383913}
Patch Set 1 #
Messages
Total messages: 13 (5 generated)
|