third_party/WebKit/Source/core/paint/SVGClipPainter.h - Issue 1838983002: Ensure display items are unique when multiple nested clip paths are used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGClipPainter.h

Issue 1838983002: Ensure display items are unique when multiple nested clip paths are used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup createContentPicture too Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp ('k') | third_party/WebKit/Source/core/paint/SVGClipPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGClipPainter.h

diff --git a/third_party/WebKit/Source/core/paint/SVGClipPainter.h b/third_party/WebKit/Source/core/paint/SVGClipPainter.h

index c511bc23a2765ae5abcf4a5f7e398a416e71140a..59acecbe8c99dcda3c2cc24099bb0b6b58bd3e19 100644

--- a/third_party/WebKit/Source/core/paint/SVGClipPainter.h

+++ b/third_party/WebKit/Source/core/paint/SVGClipPainter.h

@@ -11,6 +11,7 @@

namespace blink {

+class AffineTransform;

class GraphicsContext;

class LayoutObject;

class LayoutSVGResourceClipper;

@@ -33,7 +34,7 @@ public:

void finishEffect(const LayoutObject&, GraphicsContext&, ClipperState&);

private:

- void drawClipMaskContent(GraphicsContext&, const LayoutObject&, const FloatRect& targetBoundingBox, const FloatRect& targetPaintInvalidationRect);

+ bool drawClipAsMask(GraphicsContext&, const LayoutObject&, const FloatRect& targetBoundingBox, const FloatRect& targetPaintInvalidationRect, const AffineTransform&);

wkorman 2016/03/29 17:56:33 Please document, in particular the return value me

pdr. 2016/03/29 18:06:15 Done

LayoutSVGResourceClipper& m_clip;

};