third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h - Issue 1838983002: Ensure display items are unique when multiple nested clip paths are used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h

Issue 1838983002: Ensure display items are unique when multiple nested clip paths are used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup createContentPicture too Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/clip-path/multiple-nested-clip-paths-crash-expected.html ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h

index fd3df7bf8245ebf5ef23fe824eecdea10d906b98..46ebbbb6f8645f7380bf5ea440889949cb208347 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h

@@ -47,7 +47,7 @@ public:

SVGUnitTypes::SVGUnitType clipPathUnits() const { return toSVGClipPathElement(element())->clipPathUnits()->currentValue()->enumValue(); }

bool asPath(const AffineTransform&, const FloatRect& referenceBox, Path&);

- PassRefPtr<const SkPicture> createContentPicture(AffineTransform&, const FloatRect&, GraphicsContext&);

+ PassRefPtr<const SkPicture> createContentPicture();

bool hasCycle() { return m_inClipExpansion; }

void beginClipExpansion() { ASSERT(!m_inClipExpansion); m_inClipExpansion = true; }