Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Side by Side Diff: third_party/WebKit/Source/core/paint/SVGClipPainter.h

Issue 1838983002: Ensure display items are unique when multiple nested clip paths are used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make patch great again Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SVGClipPainter_h 5 #ifndef SVGClipPainter_h
6 #define SVGClipPainter_h 6 #define SVGClipPainter_h
7 7
8 #include "platform/geometry/FloatRect.h" 8 #include "platform/geometry/FloatRect.h"
9 #include "platform/graphics/paint/DisplayItemClient.h" 9 #include "platform/graphics/paint/DisplayItemClient.h"
10 #include "wtf/Allocator.h" 10 #include "wtf/Allocator.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class AffineTransform;
14 class GraphicsContext; 15 class GraphicsContext;
15 class LayoutObject; 16 class LayoutObject;
16 class LayoutSVGResourceClipper; 17 class LayoutSVGResourceClipper;
17 18
18 class SVGClipPainter { 19 class SVGClipPainter {
19 STACK_ALLOCATED(); 20 STACK_ALLOCATED();
20 public: 21 public:
21 enum ClipperState { 22 enum ClipperState {
22 ClipperNotApplied, 23 ClipperNotApplied,
23 ClipperAppliedPath, 24 ClipperAppliedPath,
24 ClipperAppliedMask 25 ClipperAppliedMask
25 }; 26 };
26 27
27 SVGClipPainter(LayoutSVGResourceClipper& clip) : m_clip(clip) { } 28 SVGClipPainter(LayoutSVGResourceClipper& clip) : m_clip(clip) { }
28 29
29 // FIXME: Filters are also stateful resources that could benefit from having their state managed 30 // FIXME: Filters are also stateful resources that could benefit from having their state managed
30 // on the caller stack instead of the current hashmap. We should look at refactoring these 31 // on the caller stack instead of the current hashmap. We should look at refactoring these
31 // into a general interface that can be shared. 32 // into a general interface that can be shared.
32 bool prepareEffect(const LayoutObject&, const FloatRect&, const FloatRect&, GraphicsContext&, ClipperState&); 33 bool prepareEffect(const LayoutObject&, const FloatRect&, const FloatRect&, GraphicsContext&, ClipperState&);
33 void finishEffect(const LayoutObject&, GraphicsContext&, ClipperState&); 34 void finishEffect(const LayoutObject&, GraphicsContext&, ClipperState&);
34 35
35 private: 36 private:
36 void drawClipMaskContent(GraphicsContext&, const LayoutObject&, const FloatR ect& targetBoundingBox, const FloatRect& targetPaintInvalidationRect); 37 // Return false if there is a problem drawing the mask.
38 bool drawClipAsMask(GraphicsContext&, const LayoutObject&, const FloatRect& targetBoundingBox, const FloatRect& targetPaintInvalidationRect, const AffineTra nsform&);
37 39
38 LayoutSVGResourceClipper& m_clip; 40 LayoutSVGResourceClipper& m_clip;
39 }; 41 };
40 42
41 } // namespace blink 43 } // namespace blink
42 44
43 #endif // SVGClipPainter_h 45 #endif // SVGClipPainter_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698