Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1838963002: [Downloads] Fix copy and move operators for TestDownloadRequestHandler. (Closed)

Created:
4 years, 8 months ago by asanka
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
asanka, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Fix copy and move operators for TestDownloadRequestHandler. The 'support_byte_ranges' member was not being initialized during a copy or move assignment. Interestingly, this was causing subtle flakiness only on Windows. BUG=598360 Committed: https://crrev.com/da82ea55fc1575d1950234bdebf54001c44f5a73 Cr-Commit-Position: refs/heads/master@{#383985}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M content/browser/download/download_browsertest.cc View 1 2 3 3 chunks +3 lines, -21 lines 0 comments Download
M content/public/test/test_download_request_handler.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
asanka
4 years, 8 months ago (2016-03-29 19:04:21 UTC) #3
sky
LGTM
4 years, 8 months ago (2016-03-30 15:35:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838963002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838963002/60001
4 years, 8 months ago (2016-03-30 15:51:08 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-03-30 16:04:58 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:06:44 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/da82ea55fc1575d1950234bdebf54001c44f5a73
Cr-Commit-Position: refs/heads/master@{#383985}

Powered by Google App Engine
This is Rietveld 408576698