Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/tools/crash_service/BUILD.gn

Issue 1838953003: Build crash_service_win64 with clang-cl when is_clang=true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/crash_service/BUILD.gn
diff --git a/chrome/tools/crash_service/BUILD.gn b/chrome/tools/crash_service/BUILD.gn
index df763ff9427d86ee5b97678c90ff44a165f3d91d..d24cb07f3f1828da96c54a2d4426ec735334e526 100644
--- a/chrome/tools/crash_service/BUILD.gn
+++ b/chrome/tools/crash_service/BUILD.gn
@@ -24,7 +24,13 @@ executable("crash_service") {
if (target_cpu == "x86" && current_cpu == "x86") {
# Cross-compile a 64-bit version when compiling a 64-bit target.
copy("crash_service_win64") {
- crash_service_64_target = ":crash_service(//build/toolchain/win:x64)"
+ if (is_clang) {
+ maybe_clang = "clang_"
+ } else {
+ maybe_clang = ""
+ }
+ crash_service_64_target =
+ ":crash_service(//build/toolchain/win:${maybe_clang}x64)"
Dirk Pranke 2016/03/29 18:56:08 lgtm. There's a related issue in that is_clang i
sources = [
# It would be nice if get_target_outputs would work on the executable,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698