Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1838933003: Format code in analysis_server (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -163 lines) Patch
M pkg/analysis_server/benchmark/integration/local_runner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/dependencies/reachable_source_collector.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 13 chunks +110 lines, -110 lines 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 1 chunk +35 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/stress/utilities/git.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/from_html.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-03-29 03:50:29 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-03-29 05:31:53 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-03-29 15:27:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c22a5f80718cd1304f4b94aaebdcb65a1ae81a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698