Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1838933002: wasm: hook abstract code (Closed)

Created:
4 years, 8 months ago by JF
Modified:
4 years, 8 months ago
Reviewers:
titzer, bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@is_wasm
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

wasm: hook abstract code We'll require the abstract code (as well as the offset) when we do full backtraces. R=bradnelson@chromium.org, titzer@chromium.org Committed: https://crrev.com/229cc17fab9b7047b5ada56256af61466693c250 Cr-Commit-Position: refs/heads/master@{#35116}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/isolate.cc View 1 chunk +5 lines, -1 line 1 comment Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
JF
4 years, 8 months ago (2016-03-28 23:17:40 UTC) #1
JF
https://codereview.chromium.org/1838933002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/1838933002/diff/1/src/isolate.cc#newcode432 src/isolate.cc:432: WasmFrame* wasm_frame = WasmFrame::cast(frame); Note: this relies on the ...
4 years, 8 months ago (2016-03-28 23:18:11 UTC) #2
bradn
lgtm, sans the revision suggested to the other change.
4 years, 8 months ago (2016-03-28 23:48:46 UTC) #4
titzer
lgtm
4 years, 8 months ago (2016-03-29 09:29:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838933002/1
4 years, 8 months ago (2016-03-29 17:45:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 18:07:11 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 18:08:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/229cc17fab9b7047b5ada56256af61466693c250
Cr-Commit-Position: refs/heads/master@{#35116}

Powered by Google App Engine
This is Rietveld 408576698