Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: extensions/browser/api/api_resource_manager.h

Issue 183893041: Move sockets APIs out of src/chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename api targets Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/DEPS ('k') | extensions/browser/api/socket/socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/api_resource_manager.h
diff --git a/extensions/browser/api/api_resource_manager.h b/extensions/browser/api/api_resource_manager.h
index 0513c2c517be67dfe7480d16b5205648544bedbd..39e9b8e5d675569c124471b6c797a3c65377550a 100644
--- a/extensions/browser/api/api_resource_manager.h
+++ b/extensions/browser/api/api_resource_manager.h
@@ -23,15 +23,16 @@
#include "extensions/common/extension.h"
namespace extensions {
+
namespace api {
class SerialEventDispatcher;
+}
+
+namespace core_api {
class TCPServerSocketEventDispatcher;
class TCPSocketEventDispatcher;
class UDPSocketEventDispatcher;
}
-}
-
-namespace extensions {
// An ApiResourceManager manages the lifetime of a set of resources that
// ApiFunctions use. Examples are sockets or USB connections.
@@ -149,13 +150,17 @@ class ApiResourceManager : public BrowserContextKeyedAPI,
}
private:
+ // TODO(rockot): ApiResourceData could be moved out of ApiResourceManager and
+ // we could avoid maintaining a friends list here.
friend class api::SerialEventDispatcher;
- friend class api::TCPServerSocketEventDispatcher;
- friend class api::TCPSocketEventDispatcher;
- friend class api::UDPSocketEventDispatcher;
+ friend class core_api::TCPServerSocketEventDispatcher;
+ friend class core_api::TCPSocketEventDispatcher;
+ friend class core_api::UDPSocketEventDispatcher;
friend class BrowserContextKeyedAPIFactory<ApiResourceManager<T> >;
+
// BrowserContextKeyedAPI implementation.
static const char* service_name() { return T::service_name(); }
+
static const bool kServiceHasOwnInstanceInIncognito = true;
static const bool kServiceIsNULLWhileTesting = true;
« no previous file with comments | « extensions/browser/DEPS ('k') | extensions/browser/api/socket/socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698