Move sockets APIs out of src/chrome

apps/shell/browser/shell_extensions_browser_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell/browser/shell_extensions_browser_client.h"
 
 #include "apps/shell/browser/shell_app_sorting.h"
 #include "apps/shell/browser/shell_extension_system_factory.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/pref_service_factory.h"
 #include "base/prefs/testing_pref_store.h"
 #include "chrome/common/extensions/api/generated_api.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "components/user_prefs/user_prefs.h"
 #include "extensions/browser/app_sorting.h"
 #include "extensions/browser/extension_prefs.h"
+#include "extensions/common/api/generated_api.h"
 
 using content::BrowserContext;
 
 namespace extensions {
 namespace {
 
 // See chrome::RegisterProfilePrefs() in chrome/browser/prefs/browser_prefs.cc
 void RegisterPrefs(user_prefs::PrefRegistrySyncable* registry) {
   ExtensionPrefs::RegisterProfilePrefs(registry);
 }
@@ skipping 123 matching lines @@
   return NULL;
 }
 
 ExtensionSystemProvider*
 ShellExtensionsBrowserClient::GetExtensionSystemFactory() {
   return ShellExtensionSystemFactory::GetInstance();
 }
 
 void ShellExtensionsBrowserClient::RegisterExtensionFunctions(
     ExtensionFunctionRegistry* registry) const {
-  // TODO(rockot): Remove this once we have enough APIs moved out of src/chrome
-  // See http://crbug.com/349042
+  extensions::core_api::GeneratedFunctionRegistry::RegisterAll(registry);

[Yoyo Zhou, 2014/03/06 23:50:08]

I agree, it's not ideally named right now. But I don't expect renaming
extensions::api to be a fun chore.

extensions::api and chrome_api, I think, would be my preferred final names (for
extensions::core_api and extensions::api). Then each GeneratedFunctionRegistry
belongs to a particular namespace.

[Ken Rockot(use gerrit already), 2014/03/07 00:06:36]

Great, I think we have a quorum on this. Bug filed http://crbug.com/350169

+  // TODO(rockot): Remove dependency on src/chrome once we have some core APIs
+  // moved out. See http://crbug.com/349042.
   extensions::api::GeneratedFunctionRegistry::RegisterAll(registry);
 }
 
 }  // namespace extensions