Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 183893036: telemetry: deprecate GetModernizedTestName which is not used anymore (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

telemetry: deprecate GetModernizedTestName which is not used anymore PageTestRunner.GetModernizedTestName was used to support old testnames to be specified, but it is not used anymore. The conversion map in tools/perf/run_measurement was already empty. NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255344

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M tools/perf/run_measurement View 1 1 chunk +1 line, -17 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_runner.py View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 9 months ago (2014-03-06 06:41:13 UTC) #1
tonyg
lgtm
6 years, 9 months ago (2014-03-06 06:43:30 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-06 06:47:23 UTC) #3
kouhei (in TOK)
Thanks!
6 years, 9 months ago (2014-03-06 06:47:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/183893036/20001
6 years, 9 months ago (2014-03-06 06:47:30 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 14:22:50 UTC) #6
Message was sent while issue was closed.
Change committed as 255344

Powered by Google App Engine
This is Rietveld 408576698