Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 183893031: x11: Simplify some more event-rewrite code. (Closed)

Created:
6 years, 9 months ago by sadrul
Modified:
6 years, 9 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, kalyank, ben+aura_chromium.org, ben+views_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

x11: Simplify some more event-rewrite code. The WindowTreeHost implementation for X11 currently receives an event from X11 when the keyboard mapping changes in the system. The implementation then calls into WindowTreeHost::OnKeyboardMappingChanged(), which triggers the corresponding method in all WindowTreeHostObservers. The EventRewriter is a WindowTreeHostObserver, and so it can then reset the keycodes it maintains. But the EventRewriter is also a MessagePumpObserver, which means it already receives the X11 MappingNotify event, and so the plumbing of the event through aura is unnecessary. There is no other consumer of WindowTreeHostObserver::OnKeyboardMappingChanged(), so remove it from the api. BUG=343639 R=oshima@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255185

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -37 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.h View 1 2 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 2 5 chunks +8 lines, -15 lines 0 comments Download
M ui/aura/window_tree_host.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ui/aura/window_tree_host_observer.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
oshima@ For chrome/browser/chromeos/ changes sky@ For ui/aura/ ui/views/ changes
6 years, 9 months ago (2014-03-05 19:37:52 UTC) #1
sky
nice, LGTM
6 years, 9 months ago (2014-03-05 21:29:52 UTC) #2
oshima
lgtm
6 years, 9 months ago (2014-03-05 23:03:36 UTC) #3
sadrul
6 years, 9 months ago (2014-03-06 01:06:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r255185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698