Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: gm/rebaseline_server/static/loader.js

Issue 183893030: rebaseline_server: add "show thumbnails" option, and skip display of nonexistent images (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: retry upload due to "error: old chunk mismatch" Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Loader: 2 * Loader:
3 * Reads GM result reports written out by results.py, and imports 3 * Reads GM result reports written out by results.py, and imports
4 * them into $scope.extraColumnHeaders and $scope.imagePairs . 4 * them into $scope.extraColumnHeaders and $scope.imagePairs .
5 */ 5 */
6 var Loader = angular.module( 6 var Loader = angular.module(
7 'Loader', 7 'Loader',
8 ['ConstantsModule', 'diff_viewer'] 8 ['ConstantsModule', 'diff_viewer']
9 ); 9 );
10 10
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 }, 285 },
286 'save': function(nameValuePairs, name) { 286 'save': function(nameValuePairs, name) {
287 nameValuePairs[name] = Object.keys($scope[name]).join(','); 287 nameValuePairs[name] = Object.keys($scope[name]).join(',');
288 } 288 }
289 }, 289 },
290 290
291 }; 291 };
292 292
293 // parameter name -> copier objects to load/save parameter value 293 // parameter name -> copier objects to load/save parameter value
294 $scope.queryParameters.map = { 294 $scope.queryParameters.map = {
295 'resultsToLoad': $scope.queryParameters.copiers.simple, 295 'resultsToLoad': $scope.queryParameters.copiers.simple,
296 'displayLimitPending': $scope.queryParameters.copiers.simple, 296 'displayLimitPending': $scope.queryParameters.copiers.simple,
297 'imageSizePending': $scope.queryParameters.copiers.simple, 297 'showThumbnailsPending': $scope.queryParameters.copiers.simple,
298 'sortColumnSubdict': $scope.queryParameters.copiers.simple, 298 'imageSizePending': $scope.queryParameters.copiers.simple,
299 'sortColumnKey': $scope.queryParameters.copiers.simple, 299 'sortColumnSubdict': $scope.queryParameters.copiers.simple,
300 'sortColumnKey': $scope.queryParameters.copiers.simple,
300 301
301 'hiddenResultTypes': $scope.queryParameters.copiers.set, 302 'hiddenResultTypes': $scope.queryParameters.copiers.set,
302 'hiddenConfigs': $scope.queryParameters.copiers.set, 303 'hiddenConfigs': $scope.queryParameters.copiers.set,
303 }; 304 };
304 $scope.queryParameters.map[constants.KEY__EXTRACOLUMN__BUILDER] = 305 $scope.queryParameters.map[constants.KEY__EXTRACOLUMN__BUILDER] =
305 $scope.queryParameters.copiers.categoryValueMatch; 306 $scope.queryParameters.copiers.categoryValueMatch;
306 $scope.queryParameters.map[constants.KEY__EXTRACOLUMN__TEST] = 307 $scope.queryParameters.map[constants.KEY__EXTRACOLUMN__TEST] =
307 $scope.queryParameters.copiers.categoryValueMatch; 308 $scope.queryParameters.copiers.categoryValueMatch;
308 309
309 // Loads all parameters into $scope from the URL query string; 310 // Loads all parameters into $scope from the URL query string;
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 $scope.filteredImagePairs = 390 $scope.filteredImagePairs =
390 $filter("orderBy")( 391 $filter("orderBy")(
391 $filter("filter")( 392 $filter("filter")(
392 $scope.imagePairs, 393 $scope.imagePairs,
393 {tab: $scope.viewingTab}, 394 {tab: $scope.viewingTab},
394 true 395 true
395 ), 396 ),
396 $scope.getSortColumnValue); 397 $scope.getSortColumnValue);
397 $scope.limitedImagePairs = $scope.filteredImagePairs; 398 $scope.limitedImagePairs = $scope.filteredImagePairs;
398 } 399 }
400 $scope.showThumbnails = $scope.showThumbnailsPending;
399 $scope.imageSize = $scope.imageSizePending; 401 $scope.imageSize = $scope.imageSizePending;
400 $scope.setUpdatesPending(false); 402 $scope.setUpdatesPending(false);
401 $scope.queryParameters.save(); 403 $scope.queryParameters.save();
402 } 404 }
403 405
404 /** 406 /**
405 * Re-sort the displayed results. 407 * Re-sort the displayed results.
406 * 408 *
407 * @param subdict (string): which subdictionary 409 * @param subdict (string): which subdictionary
408 * (constants.KEY__DIFFERENCE_DATA, constants.KEY__EXPECTATIONS_DATA, 410 * (constants.KEY__DIFFERENCE_DATA, constants.KEY__EXPECTATIONS_DATA,
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 */ 754 */
753 $scope.getImageDiffRelativeUrl = function(imagePair) { 755 $scope.getImageDiffRelativeUrl = function(imagePair) {
754 var before = 756 var before =
755 imagePair[constants.KEY__IMAGE_A_URL] + "-vs-" + 757 imagePair[constants.KEY__IMAGE_A_URL] + "-vs-" +
756 imagePair[constants.KEY__IMAGE_B_URL]; 758 imagePair[constants.KEY__IMAGE_B_URL];
757 return before.replace(/[^\w\-]/g, "_") + ".png"; 759 return before.replace(/[^\w\-]/g, "_") + ".png";
758 } 760 }
759 761
760 } 762 }
761 ); 763 );
OLDNEW
« no previous file with comments | « no previous file | gm/rebaseline_server/static/view.html » ('j') | gm/rebaseline_server/static/view.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698