rebaseline_server: add "show thumbnails" option, and skip display of nonexistent images

rebaseline_server: add "show thumbnails" option, and skip display of nonexistent images

BUG=skia:2248, skia:2231
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13676

[epoger, 2014-03-05 18:25:28]

Ready for review at patchset 2.

You can try it out at http://172.24.179.183:8888/static/index.html

https://codereview.chromium.org/183893030/diff/20001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/183893030/diff/20001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/view.html:26: <div ng-show="extraColumnHeaders"><!--
everything: hide until data is loaded -->
Where we are guarding against img src loading, I had to use ng-if instead of
ng-hide/ng-show.

But I found that making them all ng-if caused problems, so I wanted to leave
some of them as "show/hide" instead of "if/not-if".

I went ahead and changed all the ng-hide clauses to EITHER ng-if or ng-show, so
that the logic does not have to be inverted when we switch between the
"show/hide" and "if/not-if" approaches.

[borenet, 2014-03-05 19:03:55]

LGTM, though I'm no Angular expert.

https://codereview.chromium.org/183893030/diff/20001/gm/rebaseline_server/sta...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/183893030/diff/20001/gm/rebaseline_server/sta...
gm/rebaseline_server/static/view.html:26: <div ng-show="extraColumnHeaders"><!--
everything: hide until data is loaded -->
On 2014/03/05 18:25:28, epoger wrote:
> Where we are guarding against img src loading, I had to use ng-if instead of
> ng-hide/ng-show.
> 
> But I found that making them all ng-if caused problems, so I wanted to leave
> some of them as "show/hide" instead of "if/not-if".
> 

Just curious - what problems did use of ng-if instead of ng-show cause?
> I went ahead and changed all the ng-hide clauses to EITHER ng-if or ng-show,
so
> that the logic does not have to be inverted when we switch between the
> "show/hide" and "if/not-if" approaches.

Thanks. Using consistently "positive" terms is helpful.

[epoger, 2014-03-05 19:45:05]

On 2014/03/05 19:03:55, borenet wrote:
> LGTM, though I'm no Angular expert.

This, of course, is why I asked you to review it.

> Just curious - what problems did use of ng-if instead of ng-show cause?

As usual in AngularWorld, the problems were very mysterious.  When I clicked on
the "Update Results" button, nothing would happen.

[epoger, 2014-03-05 19:45:15]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-05 19:45:35]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/183893030/20001

[commit-bot: I haz the power, 2014-03-05 19:46:20]

Change committed as 13676