Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 183893029: Add UI hook for distilling web pages for test shell (relanding) (Closed)

Created:
6 years, 9 months ago by nyquist
Modified:
6 years, 9 months ago
Reviewers:
cjhopman, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Add UI hook for distilling web pages for test shell (relanding) This adds the Java hooks needed and a menu option to distill the current web page in the test shell. Original CL: https://codereview.chromium.org/185113002/ BUG=319881 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255369

Patch Set 1 #

Patch Set 2 : Added fix #

Patch Set 3 : Rebased after move from chrome/android/testshell to chrome/android/shell #

Patch Set 4 : Fix DEPS after wrong rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -7 lines) Patch
M chrome/android/shell/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 2 4 chunks +11 lines, -0 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/TestShellSwitches.java View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/android/shell/res/menu/main_menu.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/shell/res/values/strings.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_android.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/dom_distiller.gypi View 3 chunks +37 lines, -0 lines 0 comments Download
M components/dom_distiller/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A components/dom_distiller/android/component_jni_registrar.h View 1 chunk +21 lines, -0 lines 0 comments Download
A components/dom_distiller/android/component_jni_registrar.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A components/dom_distiller/android/java/src/org/chromium/components/dom_distiller/core/DomDistillerUrlUtils.java View 1 chunk +30 lines, -0 lines 0 comments Download
A components/dom_distiller/core/url_utils_android.h View 1 chunk +27 lines, -0 lines 0 comments Download
A components/dom_distiller/core/url_utils_android.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
nyquist
cjhopman: PTAL
6 years, 9 months ago (2014-03-05 17:21:31 UTC) #1
nyquist
thakis: PTAL chrome/chrome.gyp for OWNERS review The dom_distiller_core_java dependency is moved from chromium_testshell to chrome_java. ...
6 years, 9 months ago (2014-03-05 18:12:15 UTC) #2
cjhopman
lgtm.
6 years, 9 months ago (2014-03-05 18:30:55 UTC) #3
Nico
gyp lgtm
6 years, 9 months ago (2014-03-05 23:50:36 UTC) #4
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 9 months ago (2014-03-06 00:46:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/183893029/20001
6 years, 9 months ago (2014-03-06 00:49:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 00:49:47 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromiumTestShellActivity.java: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 9 months ago (2014-03-06 00:49:48 UTC) #8
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 9 months ago (2014-03-06 06:08:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/183893029/60001
6 years, 9 months ago (2014-03-06 06:10:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 06:27:08 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=276165
6 years, 9 months ago (2014-03-06 06:27:09 UTC) #12
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 9 months ago (2014-03-06 14:19:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/183893029/60001
6 years, 9 months ago (2014-03-06 14:23:53 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 16:48:44 UTC) #15
Message was sent while issue was closed.
Change committed as 255369

Powered by Google App Engine
This is Rietveld 408576698