Use a correct scale factor for Gaia avatar images

Use a correct scale factor for Gaia avatar images

BUG=341607
TEST=Make sure that you have the --new-profile-management flag turned on, at least two profiles, and at least one of them signed in. Go to chrome://settings. All the users should display an avatar image in the Users section, including the signed in users, which will have their Gaia photo.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255367

[noms (inactive), 2014-03-05 18:15:30]

Hi Nico,

I tried to fix the image-set bug where the Gaia photos don't have a 2x version,
and wouldn't display in chrome://settings, but I'm not sure it's entirely right.
Since the imageset() method expects a scalefactor to be present in the image
path, i'm just not passing one, and the function doesn't do anything. Does this
look like it's right?

[Nico, 2014-03-05 18:59:44]

Hm, imageset() is for a set of images. If only have a single image for gaia
avatars, I'd not use an imageset for them I think.

So I'd have a function that returns an imageset for non-gaia avatars (since
those have 2 images) and just a regular image directly, else.

[noms (inactive), 2014-03-05 23:10:16]

Oh, that would make more sense. Please take another look, I think it may be
better now. Or at least worse in new ways :)

[Nico, 2014-03-05 23:38:00]

That's better, your change lgtm. (Go ahead and land.)

However, I don't understand the "@scalefactorx" that akuegel added in
https://codereview.chromium.org/100073004/ – akuegel, what's that supposed to
do?

[noms (inactive), 2014-03-05 23:38:59]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-03-05 23:41:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/183893028/20002

[Nico, 2014-03-05 23:43:19]

noms kindly explained to over chat that scalefactorx is expanded 10 lines below
her function, sorry :-/

[Nico, 2014-03-05 23:44:16]

*…explained to me over chat…


On Wed, Mar 5, 2014 at 3:43 PM, <thakis@chromium.org> wrote:

> noms kindly explained to over chat that scalefactorx is expanded 10 lines
> below
> her function, sorry :-/
>
> https://codereview.chromium.org/183893028/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-03-06 00:19:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/183893028/20002

[commit-bot: I haz the power, 2014-03-06 00:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 00:41:33]

Try jobs failed on following builders: mac_chromium_rel

[noms (inactive), 2014-03-06 14:16:42]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-03-06 14:17:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/183893028/20002

[commit-bot: I haz the power, 2014-03-06 16:48:10]

Change committed as 255367