LayoutTests/editing/execCommand/resources/insert-image-changing-visibility-crash-iframe.html - Issue 183893018: Check VisualPosition.isNull() after DOM mutation in ReplaceSelectionCommand

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/resources/insert-image-changing-visibility-crash-iframe.html

Issue 183893018: Check VisualPosition.isNull() after DOM mutation in ReplaceSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/editing/execCommand/insert-image-changing-visibility-crash-expected.txt ('k') | Source/core/editing/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Issue 348283 crash test case</title>

	5 </head>

	6 <!-- This is a minified version of the clusterfuzz test case at https://code.goo gle.com/p/chromium/issues/detail?id=348283 -->

	7 <body contenteditable="true">

	8 <script>

	9 window.onload = function () {

	10 var table = document.getElementById("table");

	11 table.insertAdjacentHTML('afterbegin', "<svg/><div><div id=\"div\">text</div >");
	Yuta Kitamura 2014/03/04 06:36:18 nit: Don't use both '' and "" for string literals nit: Don't use both '' and "" for string literals in one file. yoichio 2014/03/04 07:05:56 Done. Show quoted text On 2014/03/04 06:36:18, Yuta Kitamura wrote: > nit: Don't use both '' and "" for string literals > in one file. Done.
	12

	13 var div = document.getElementById("div");

	14 var selection = window.getSelection();

	15 selection.collapse(div.firstChild, 0);

	16 document.execCommand('InsertImage', false, 'about:blank');

	17 window.parent.postMessage('FINISH', '*');

	18 };

	19 </script>

	20 <style>
	Yuta Kitamura 2014/03/04 06:36:18 nit: <style> usually appears within <head>. nit: <style> usually appears within <head>. yoichio 2014/03/04 07:05:56 Done. Show quoted text On 2014/03/04 06:36:18, Yuta Kitamura wrote: > nit: <style> usually appears within <head>. Done.
	21 table {

	22 visibility: collapse;

	23 }

	24

	25 *:only-child {

	26 visibility: visible;

	27 }

	28 </style>

	29 <table id="table" />
	Yuta Kitamura 2014/03/04 06:36:18 nit: "<xxx />"-style tag should probably only be u nit: "<xxx />"-style tag should probably only be used within XML (or so-called XHTML5). I know it's allowed within HTML5 documents, but I prefer to stick with HTML notations for HTML documents. yoichio 2014/03/04 07:05:56 Done. Show quoted text On 2014/03/04 06:36:18, Yuta Kitamura wrote: > nit: "<xxx />"-style tag should probably only be used > within XML (or so-called XHTML5). I know it's allowed > within HTML5 documents, but I prefer to stick with > HTML notations for HTML documents. Done.
	30 <div />

	31 </body>

	32 </html>

OLD	NEW