Issue 183893014: Add needsrebaseline to test broken by chrome-side url changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183893014: Add needsrebaseline to test broken by chrome-side url changes. (Closed)

Created:
6 years, 9 months ago by Tom Sepez

Modified:
6 years, 9 months ago

Reviewers:
cbiesinger

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add needsrebaseline to test broken by chrome-side url changes. BUG=346132 TBR=cbiesinger@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168336

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	LayoutTests/TestExpectations	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Committed patchset #2 manually as r168336 (presubmit successful).

6 years, 9 months ago (2014-03-03 23:08:51 UTC) #1

cbiesinger

6 years, 9 months ago (2014-03-03 23:25:27 UTC) #2

Message was sent while issue was closed.

On 2014/03/03 23:08:51, Tom Sepez wrote:
> Committed patchset #2 manually as r168336 (presubmit successful).

this will commit an expected result containing the FAIL lines :(

you need to change the test itself, to change the expected result. i.e.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Expand Messages | Collapse Messages