Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 183893005: A64: fix cctest/test-assembler-a64 (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
Reviewers:
ulan, jbramley
CC:
v8-dev
Visibility:
Public.

Description

A64: fix cctest/test-assembler-a64 The simulator now deletes its decoder in its dtor. Therefore, we must always allocate the decoder on the heap. BUG=none R=ulan@chromium.org, jacob.bramley@arm.com LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M test/cctest/test-assembler-a64.cc View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-02-28 10:22:04 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-02-28 10:29:37 UTC) #2
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-02-28 10:31:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19596 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698