Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1838903006: [Media Router] Cherrypick "add sinks to origin list" to beta (Closed)

Created:
4 years, 8 months ago by imcheng
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, media-router+watch_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Media Router] Cherrypick "add sinks to origin list" to beta Attempt 2. Previous attempt was rolled back due to test failures. Original CL: https://codereview.chromium.org/1784533004 Attempt 1: https://codereview.chromium.org/1806153002/ BUG=594858 Committed: https://chromium.googlesource.com/chromium/src/+/992d9e476c70ff9b2113090919c62ee02afb0a4c

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -117 lines) Patch
M chrome/browser/media/android/router/media_router_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router.mojom View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.cc View 5 chunks +28 lines, -10 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl_unittest.cc View 4 chunks +22 lines, -8 lines 0 comments Download
M chrome/browser/media/router/media_sinks_observer.h View 3 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/media/router/media_sinks_observer.cc View 2 chunks +24 lines, -2 lines 0 comments Download
A chrome/browser/media/router/media_sinks_observer_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 1 6 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc View 4 chunks +21 lines, -9 lines 0 comments Download
M chrome/browser/media/router/test_helper.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/media/router/test_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_media_router.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 3 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager.h View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc View 10 chunks +27 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/media_router/media_router_e2e_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/media_router/test_media_sinks_observer.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/media_router/test_media_sinks_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
4 years, 8 months ago (2016-03-30 07:01:00 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
992d9e476c70ff9b2113090919c62ee02afb0a4c.

Powered by Google App Engine
This is Rietveld 408576698