Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1838863004: [Chromecast] Clear cached video plane geometry parameters and don't run (Closed)

Created:
4 years, 8 months ago by esum
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Clear cached video plane geometry parameters and don't run SetGeometry when graphics plane resolution changes. Reasons for this: * When switching to an app with a different graphics plane resolution, the old video plane geometry parameters are now invalid since they were relative to the previous graphics plane. * SetGeometry should not always be run when the graphics plane resolution changes because some apps (like Backdrop) don't have a video element. BUG=internal b/27554486 TEST=All tests run on dragonfly * Switch Youtube -> Backdrop. No SetGeometry calls are made after switching to Backdrop. * Switch Youtube -> Netflix. SetGeometry calls are made for Netflix playback. * Revoke resources while playing Youtube video. Then grant resources and playback same Youtube video. SetGeometry call is made when Youtube video is played again. Committed: https://crrev.com/f53fdccff6804b1a262551898ddb11ad6d9e336c Cr-Commit-Position: refs/heads/master@{#383839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -57 lines) Patch
M chromecast/media/base/video_plane_controller.h View 3 chunks +22 lines, -28 lines 0 comments Download
M chromecast/media/base/video_plane_controller.cc View 8 chunks +36 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
esum
4 years, 8 months ago (2016-03-29 03:49:46 UTC) #2
halliwell
On 2016/03/29 03:49:46, esum wrote: lgtm. I'd like to add some tests for this class, ...
4 years, 8 months ago (2016-03-29 13:28:43 UTC) #3
esum
On 2016/03/29 13:28:43, halliwell wrote: > On 2016/03/29 03:49:46, esum wrote: > > lgtm. I'd ...
4 years, 8 months ago (2016-03-29 20:56:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838863004/1
4 years, 8 months ago (2016-03-29 20:57:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 21:52:06 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:53:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f53fdccff6804b1a262551898ddb11ad6d9e336c
Cr-Commit-Position: refs/heads/master@{#383839}

Powered by Google App Engine
This is Rietveld 408576698