Print more information when slow-path/fast-path rects mismatch

Print more information when slow-path/fast-path rects mismatch

Also added code to tolerate rounding difference between fast-path and slow-path
when crossing frame boundaries (see crbug.com/594516).

Committed: https://crrev.com/21b64d8710e2844c30e53fcfb4e70aa5eacdf999
Cr-Commit-Position: refs/heads/master@{#384403}

[Xianzhu, 2016-03-30 21:29:20]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-03-30 22:37:40]

Added code to tolerate the difference.

[chrishtr, 2016-03-31 00:27:13]

https://codereview.chromium.org/1838853007/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp (left):

https://codereview.chromium.org/1838853007/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp:291: if
(object.isBox() && (toLayoutBox(object).isWritingModeRoot() || (ancestor ==
object && object.styleRef().isFlippedBlocksWritingMode())))
Put this into the CL description (at the top since it's a behavior change).

This change caused no tests to fail though. Sort of along those lines, can you
add an explicit test for mapToVisualRectInAncestorSpace alongside the other few
we have that exercises flipped blocks?

[Xianzhu, 2016-03-31 00:45:23]

Patchset #5 (id:80001) has been deleted

[Xianzhu, 2016-03-31 00:47:58]

Description was changed from

==========
Print more information when slow-path/fast-path rects mismatch
==========

to

==========
Print more information when slow-path/fast-path rects mismatch

Also added code to tolerate rounding difference between fast-path and slow-path
when crossing frame boundaries (see crbug.com/594516).
==========

[Xianzhu, 2016-03-31 00:48:08]

https://codereview.chromium.org/1838853007/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp (left):

https://codereview.chromium.org/1838853007/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp:291: if
(object.isBox() && (toLayoutBox(object).isWritingModeRoot() || (ancestor ==
object && object.styleRef().isFlippedBlocksWritingMode())))
On 2016/03/31 00:27:12, chrishtr wrote:
> Put this into the CL description (at the top since it's a behavior change).
> 
> This change caused no tests to fail though. Sort of along those lines, can you
> add an explicit test for mapToVisualRectInAncestorSpace alongside the other
few
> we have that exercises flipped blocks?

It's wrong to change this in this CL. Reverted to Patch Set 3. Will address this
in another CL.

[chrishtr, 2016-03-31 16:17:43]

lgtm

[Xianzhu, 2016-03-31 16:27:17]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:27:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838853007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838853007/100001

[commit-bot: I haz the power, 2016-03-31 16:32:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:32:09]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xianzhu, 2016-03-31 20:34:37]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-03-31 20:35:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838853007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838853007/100001

[commit-bot: I haz the power, 2016-03-31 21:49:14]

Description was changed from

==========
Print more information when slow-path/fast-path rects mismatch

Also added code to tolerate rounding difference between fast-path and slow-path
when crossing frame boundaries (see crbug.com/594516).
==========

to

==========
Print more information when slow-path/fast-path rects mismatch

Also added code to tolerate rounding difference between fast-path and slow-path
when crossing frame boundaries (see crbug.com/594516).
==========

[commit-bot: I haz the power, 2016-03-31 21:49:15]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-03-31 21:51:02]

Description was changed from

==========
Print more information when slow-path/fast-path rects mismatch

Also added code to tolerate rounding difference between fast-path and slow-path
when crossing frame boundaries (see crbug.com/594516).
==========

to

==========
Print more information when slow-path/fast-path rects mismatch

Also added code to tolerate rounding difference between fast-path and slow-path
when crossing frame boundaries (see crbug.com/594516).

Committed: https://crrev.com/21b64d8710e2844c30e53fcfb4e70aa5eacdf999
Cr-Commit-Position: refs/heads/master@{#384403}
==========

[commit-bot: I haz the power, 2016-03-31 21:51:03]

Patchset 5 (id:??) landed as
https://crrev.com/21b64d8710e2844c30e53fcfb4e70aa5eacdf999
Cr-Commit-Position: refs/heads/master@{#384403}