Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: chrome/browser/ui/omnibox/location_bar.cc

Issue 183883033: Move bookmarks_ui manifest key from chrome_settings_overrides to chrome_ui_overrides (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_keybinding_apitest.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/location_bar.cc
diff --git a/chrome/browser/ui/omnibox/location_bar.cc b/chrome/browser/ui/omnibox/location_bar.cc
index 5f6b358fd2b6fae5da111d4fea569ec08f673dbb..d46ce98f29c1187c8118b69d1372edcc59664aa2 100644
--- a/chrome/browser/ui/omnibox/location_bar.cc
+++ b/chrome/browser/ui/omnibox/location_bar.cc
@@ -7,7 +7,8 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/extensions/manifest_handlers/settings_overrides_handler.h"
-#include "extensions/browser/extension_system.h"
+#include "chrome/common/extensions/manifest_handlers/ui_overrides_handler.h"
+#include "extensions/browser/extension_registry.h"
#include "extensions/common/extension_set.h"
#include "extensions/common/feature_switch.h"
#include "extensions/common/permissions/permissions_data.h"
@@ -20,21 +21,19 @@ LocationBar::~LocationBar() {
}
bool LocationBar::IsBookmarkStarHiddenByExtension() const {
- const ExtensionService* extension_service =
- extensions::ExtensionSystem::Get(profile_)->extension_service();
- // Extension service may be NULL during unit test execution.
- if (!extension_service)
- return false;
-
- const extensions::ExtensionSet* extension_set =
- extension_service->extensions();
- for (extensions::ExtensionSet::const_iterator i = extension_set->begin();
- i != extension_set->end(); ++i) {
+ const extensions::ExtensionSet& extension_set =
+ extensions::ExtensionRegistry::Get(profile_)->enabled_extensions();
+ for (extensions::ExtensionSet::const_iterator i = extension_set.begin();
+ i != extension_set.end(); ++i) {
+ using extensions::UIOverrides;
using extensions::SettingsOverrides;
+ const UIOverrides* ui_overrides = UIOverrides::Get(i->get());
const SettingsOverrides* settings_overrides =
SettingsOverrides::Get(i->get());
- if (settings_overrides &&
- SettingsOverrides::RemovesBookmarkButton(*settings_overrides) &&
+ if (((settings_overrides &&
+ SettingsOverrides::RemovesBookmarkButton(*settings_overrides)) ||
+ (ui_overrides &&
+ UIOverrides::RemovesBookmarkButton(*ui_overrides))) &&
(extensions::PermissionsData::HasAPIPermission(
*i,
extensions::APIPermission::kBookmarkManagerPrivate) ||
« no previous file with comments | « chrome/browser/extensions/extension_keybinding_apitest.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698