Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183883025: Sync iOS DEPS overrides with downstream (Closed)

Created:
6 years, 9 months ago by stuartmorgan
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Sync iOS DEPS overrides with downstream The list has drifted over time during merges; this re-aligns with the current state. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255454

Patch Set 1 #

Patch Set 2 : Added layout tests #

Patch Set 3 : Added layout tests, trying again #

Total comments: 2

Patch Set 4 : Fix ordering #

Total comments: 1

Patch Set 5 : Disable input_speech #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M DEPS View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M build/common.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
stuartmorgan
6 years, 9 months ago (2014-03-05 23:38:24 UTC) #1
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/183883025/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/183883025/diff/40001/DEPS#newcode394 DEPS:394: "src/third_party/libc++abi/trunk": None, These come after libaddressinput?
6 years, 9 months ago (2014-03-06 00:02:37 UTC) #2
stuartmorgan
https://codereview.chromium.org/183883025/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/183883025/diff/40001/DEPS#newcode394 DEPS:394: "src/third_party/libc++abi/trunk": None, On 2014/03/06 00:02:37, rohitrao wrote: > These ...
6 years, 9 months ago (2014-03-06 03:48:11 UTC) #3
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 9 months ago (2014-03-06 03:48:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/183883025/60001
6 years, 9 months ago (2014-03-06 03:50:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 04:11:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-06 04:11:11 UTC) #7
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 9 months ago (2014-03-06 04:27:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/183883025/60001
6 years, 9 months ago (2014-03-06 04:28:26 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 04:46:19 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=121665
6 years, 9 months ago (2014-03-06 04:46:19 UTC) #11
rohitrao (ping after 24h)
https://codereview.chromium.org/183883025/diff/60001/DEPS File DEPS (right): https://codereview.chromium.org/183883025/diff/60001/DEPS#newcode410 DEPS:410: "src/third_party/speex": None, Looks like something is still depending on ...
6 years, 9 months ago (2014-03-06 13:46:49 UTC) #12
stuartmorgan
On 2014/03/06 13:46:49, rohitrao wrote: > Looks like something is still depending on speex. Thanks, ...
6 years, 9 months ago (2014-03-06 15:27:02 UTC) #13
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 9 months ago (2014-03-06 15:27:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/183883025/80001
6 years, 9 months ago (2014-03-06 15:27:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/183883025/80001
6 years, 9 months ago (2014-03-06 20:48:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/183883025/80001
6 years, 9 months ago (2014-03-06 21:38:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/183883025/80001
6 years, 9 months ago (2014-03-06 22:13:05 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 22:46:47 UTC) #19
Message was sent while issue was closed. 
Change committed as 255454

Powered by Google App Engine
This is Rietveld 408576698