Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 183883013: Hook up the experimental ns to APM in chrome. (Closed)

Created:
6 years, 9 months ago by no longer working on chromium
Modified:
6 years, 9 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Hook up the experimental ns to APM in chrome. BUG=264611 TEST=content_unittests, nothing breaks. R=grunell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254758

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M content/renderer/media/media_stream_audio_processor.cc View 4 chunks +11 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
no longer working on chromium
Henrik, please review. Thanks, SX
6 years, 9 months ago (2014-03-04 11:21:05 UTC) #1
Henrik Grunell
lgtm
6 years, 9 months ago (2014-03-04 11:37:43 UTC) #2
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 9 months ago (2014-03-04 11:43:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/183883013/1
6 years, 9 months ago (2014-03-04 11:44:04 UTC) #4
no longer working on chromium
6 years, 9 months ago (2014-03-04 14:19:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r254758 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698