Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: src/objects.cc

Issue 183883011: Differentate between code target pointers and heap pointers in constant pools. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Minor fix to ConstantPoolArray visiting Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 0a5b69f925acaf07d64269a9eb05fd4abab887b1..8c7081c75b23b31412e74baee87955399ae0bd1b 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -9466,13 +9466,14 @@ bool Map::EquivalentToForNormalization(Map* other,
void ConstantPoolArray::ConstantPoolIterateBody(ObjectVisitor* v) {
- if (count_of_ptr_entries() > 0) {
- int first_ptr_offset = OffsetOfElementAt(first_ptr_index());
- int last_ptr_offset =
- OffsetOfElementAt(first_ptr_index() + count_of_ptr_entries() - 1);
- v->VisitPointers(
- HeapObject::RawField(this, first_ptr_offset),
- HeapObject::RawField(this, last_ptr_offset));
+ for (int i = 0; i < count_of_code_ptr_entries(); i++) {
+ int offset = OffsetOfElementAt(first_code_ptr_index() + i);
Michael Starzinger 2014/03/07 15:07:47 nit: Two white-spaces after equal sign.
rmcilroy 2014/03/10 14:03:05 Done.
+ v->VisitCodeEntry(
+ reinterpret_cast<Address>(HeapObject::RawField(this, offset)));
+ }
+ for (int i = 0; i < count_of_heap_ptr_entries(); i++) {
+ int offset = OffsetOfElementAt(first_heap_ptr_index() + i);
Michael Starzinger 2014/03/07 15:07:47 nit: Two white-spaces after equal sign.
rmcilroy 2014/03/10 14:03:05 Done.
+ v->VisitPointer(HeapObject::RawField(this, offset));
}
}

Powered by Google App Engine
This is Rietveld 408576698