src/heap.h - Issue 183883011: Differentate between code target pointers and heap pointers in constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.h

Issue 183883011: Differentate between code target pointers and heap pointers in constant pools. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Always initialize and verify constant pool code entries Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.h

diff --git a/src/heap.h b/src/heap.h

index 1ac4dfaa0808848947834983bd862aa0fc9f44d2..99abab147aab7580c8eaac95472df847d00c6ee1 100644

--- a/src/heap.h

+++ b/src/heap.h

@@ -1011,7 +1011,8 @@ class Heap {

MUST_USE_RESULT MaybeObject* AllocateConstantPoolArray(

int first_int64_index,

Michael Starzinger 2014/03/10 15:00:38 nit: For the sake of consistency could we prefix t

rmcilroy 2014/03/10 16:55:20 Oops good catch - thanks! Done

- int first_ptr_index,

+ int first_code_ptr_index,

+ int first_heap_ptr_index,

int first_int32_index);

// Allocates a fixed double array with uninitialized values. Returns

« no previous file with comments | « src/factory.cc ('k') | src/heap.cc » ('j') | src/objects.cc » ('J')