Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: src/objects-printer.cc

Issue 183883011: Differentate between code target pointers and heap pointers in constant pools. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-inl.h ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 } 599 }
600 } 600 }
601 PrintF(out, "\n"); 601 PrintF(out, "\n");
602 } 602 }
603 603
604 604
605 void ConstantPoolArray::ConstantPoolArrayPrint(FILE* out) { 605 void ConstantPoolArray::ConstantPoolArrayPrint(FILE* out) {
606 HeapObject::PrintHeader(out, "ConstantPoolArray"); 606 HeapObject::PrintHeader(out, "ConstantPoolArray");
607 PrintF(out, " - length: %d", length()); 607 PrintF(out, " - length: %d", length());
608 for (int i = 0; i < length(); i++) { 608 for (int i = 0; i < length(); i++) {
609 if (i < first_ptr_index()) { 609 if (i < first_code_ptr_index()) {
610 PrintF(out, "\n [%d]: double: %g", i, get_int64_entry_as_double(i)); 610 PrintF(out, "\n [%d]: double: %g", i, get_int64_entry_as_double(i));
611 } else if (i < first_heap_ptr_index()) {
612 PrintF(out, "\n [%d]: code target pointer: %p", i,
613 reinterpret_cast<void*>(get_code_ptr_entry(i)));
611 } else if (i < first_int32_index()) { 614 } else if (i < first_int32_index()) {
612 PrintF(out, "\n [%d]: pointer: %p", i, 615 PrintF(out, "\n [%d]: heap pointer: %p", i,
613 reinterpret_cast<void*>(get_ptr_entry(i))); 616 reinterpret_cast<void*>(get_heap_ptr_entry(i)));
614 } else { 617 } else {
615 PrintF(out, "\n [%d]: int32: %d", i, get_int32_entry(i)); 618 PrintF(out, "\n [%d]: int32: %d", i, get_int32_entry(i));
616 } 619 }
617 } 620 }
618 PrintF(out, "\n"); 621 PrintF(out, "\n");
619 } 622 }
620 623
621 624
622 void JSValue::JSValuePrint(FILE* out) { 625 void JSValue::JSValuePrint(FILE* out) {
623 HeapObject::PrintHeader(out, "ValueObject"); 626 HeapObject::PrintHeader(out, "ValueObject");
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
1229 } 1232 }
1230 } 1233 }
1231 PrintF(out, "\n"); 1234 PrintF(out, "\n");
1232 } 1235 }
1233 1236
1234 1237
1235 #endif // OBJECT_PRINT 1238 #endif // OBJECT_PRINT
1236 1239
1237 1240
1238 } } // namespace v8::internal 1241 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698