Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: src/factory.cc

Issue 183883011: Differentate between code target pointers and heap pointers in constant pools. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/factory.h ('k') | src/heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 ASSERT(0 <= size); 74 ASSERT(0 <= size);
75 CALL_HEAP_FUNCTION( 75 CALL_HEAP_FUNCTION(
76 isolate(), 76 isolate(),
77 isolate()->heap()->AllocateUninitializedFixedDoubleArray(size, pretenure), 77 isolate()->heap()->AllocateUninitializedFixedDoubleArray(size, pretenure),
78 FixedDoubleArray); 78 FixedDoubleArray);
79 } 79 }
80 80
81 81
82 Handle<ConstantPoolArray> Factory::NewConstantPoolArray( 82 Handle<ConstantPoolArray> Factory::NewConstantPoolArray(
83 int number_of_int64_entries, 83 int number_of_int64_entries,
84 int number_of_ptr_entries, 84 int number_of_code_ptr_entries,
85 int number_of_heap_ptr_entries,
85 int number_of_int32_entries) { 86 int number_of_int32_entries) {
86 ASSERT(number_of_int64_entries > 0 || number_of_ptr_entries > 0 || 87 ASSERT(number_of_int64_entries > 0 || number_of_code_ptr_entries > 0 ||
87 number_of_int32_entries > 0); 88 number_of_heap_ptr_entries > 0 || number_of_int32_entries > 0);
88 CALL_HEAP_FUNCTION( 89 CALL_HEAP_FUNCTION(
89 isolate(), 90 isolate(),
90 isolate()->heap()->AllocateConstantPoolArray(number_of_int64_entries, 91 isolate()->heap()->AllocateConstantPoolArray(number_of_int64_entries,
91 number_of_ptr_entries, 92 number_of_code_ptr_entries,
93 number_of_heap_ptr_entries,
92 number_of_int32_entries), 94 number_of_int32_entries),
93 ConstantPoolArray); 95 ConstantPoolArray);
94 } 96 }
95 97
96 98
97 Handle<NameDictionary> Factory::NewNameDictionary(int at_least_space_for) { 99 Handle<NameDictionary> Factory::NewNameDictionary(int at_least_space_for) {
98 ASSERT(0 <= at_least_space_for); 100 ASSERT(0 <= at_least_space_for);
99 CALL_HEAP_FUNCTION(isolate(), 101 CALL_HEAP_FUNCTION(isolate(),
100 NameDictionary::Allocate(isolate()->heap(), 102 NameDictionary::Allocate(isolate()->heap(),
101 at_least_space_for), 103 at_least_space_for),
(...skipping 1888 matching lines...) Expand 10 before | Expand all | Expand 10 after
1990 return Handle<Object>::null(); 1992 return Handle<Object>::null();
1991 } 1993 }
1992 1994
1993 1995
1994 Handle<Object> Factory::ToBoolean(bool value) { 1996 Handle<Object> Factory::ToBoolean(bool value) {
1995 return value ? true_value() : false_value(); 1997 return value ? true_value() : false_value();
1996 } 1998 }
1997 1999
1998 2000
1999 } } // namespace v8::internal 2001 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/factory.h ('k') | src/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698