Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 183883009: Revert of Don't setStyle the RenderView every style recalc (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis, eseidel, ojan, mstensho (USE GERRIT)
Visibility:
Public.

Description

Revert of Don't setStyle the RenderView every style recalc (https://codereview.chromium.org/185263002/) Reason for revert: Crash-broke fast/images/link-body-content-imageDimensionChanged-crash.html on "WebKit Android (Nexus 4)" Original issue's description: > Don't setStyle the RenderView every style recalc > > Prior to this CL, we were setting the style of the RenderView on every style > recalc because we were comparing the RenderView's overflow style with the wrong > value. This CL corrects the bug. > > This CL doesn't have much effect yet, but it will become important in a future > CL when we use style modification on RenderLayers to scope compositing updates. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168254 TBR=eseidel@chromium.org,esprehn@chromium.org,ojan@chromium.org,abarth@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +16 lines, -20 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
apavlov
Created Revert of Don't setStyle the RenderView every style recalc
6 years, 9 months ago (2014-03-03 09:24:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/183883009/1
6 years, 9 months ago (2014-03-03 09:25:02 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 09:25:38 UTC) #3
Message was sent while issue was closed.
Change committed as 168283

Powered by Google App Engine
This is Rietveld 408576698