Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: server/logdog/storage/storage.go

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split
Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « server/logdog/storage/memory/memory_test.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: server/logdog/storage/storage.go
diff --git a/server/logdog/storage/storage.go b/server/logdog/storage/storage.go
index 57b2da4f24870fc63a0ea91ad6b638ce2064af7b..3ef64078db637de73daf4780c07c6c7d28e2ff5f 100644
--- a/server/logdog/storage/storage.go
+++ b/server/logdog/storage/storage.go
@@ -43,8 +43,9 @@ type PutRequest struct {
// Index is the entry's stream index.
Index types.MessageIndex
- // Value is the contents of the cell to add.
- Value []byte
+ // Values are contiguous sequential records to add to the storage. The first
+ // index in values corresponds to Index.
+ Values [][]byte
}
// GetRequest is a request to retrieve a series of LogEntry records.
@@ -81,7 +82,7 @@ type Storage interface {
// Writes log record data to storage.
//
// If the data already exists, ErrExists will be returned.
- Put(*PutRequest) error
+ Put(PutRequest) error
// Get invokes a callback over a range of sequential LogEntry records.
//
@@ -96,7 +97,7 @@ type Storage interface {
// Returns nil if retrieval executed successfully, ErrDoesNotExist if
// the requested stream does not exist, and an error if an error occurred
// during retrieval.
- Get(*GetRequest, GetCallback) error
+ Get(GetRequest, GetCallback) error
// Tail retrieves the latest log in the stream. If the stream has no logs, it
// will return ErrDoesNotExist.
« no previous file with comments | « server/logdog/storage/memory/memory_test.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698