Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: server/internal/logdog/collector/utils_test.go

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split
Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « server/internal/logdog/collector/collector_test.go ('k') | server/internal/logdog/service/service.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: server/internal/logdog/collector/utils_test.go
diff --git a/server/internal/logdog/collector/utils_test.go b/server/internal/logdog/collector/utils_test.go
index 09e2b367759289b998fcd91535ce95a392c960fa..20677b7cd909415ba38b5920697a73714c39b8fc 100644
--- a/server/internal/logdog/collector/utils_test.go
+++ b/server/internal/logdog/collector/utils_test.go
@@ -124,7 +124,7 @@ type testStorage struct {
err func() error
}
-func (s *testStorage) Put(r *storage.PutRequest) error {
+func (s *testStorage) Put(r storage.PutRequest) error {
if s.err != nil {
if err := s.err(); err != nil {
return err
@@ -209,6 +209,7 @@ func (b *bundleBuilder) logEntry(idx int) *logpb.LogEntry {
func (b *bundleBuilder) bundle() []byte {
bytes := b.bundleWithEntries(b.entries...)
b.entries = nil
+
return bytes
}
@@ -283,7 +284,7 @@ func shouldHaveStoredStream(actual interface{}, expected ...interface{}) string
entries := make(map[int]*logpb.LogEntry)
var ierr error
- err := st.Get(&req, func(idx types.MessageIndex, d []byte) bool {
+ err := st.Get(req, func(idx types.MessageIndex, d []byte) bool {
le := logpb.LogEntry{}
if ierr = proto.Unmarshal(d, &le); ierr != nil {
return false
@@ -316,7 +317,7 @@ func shouldHaveStoredStream(actual interface{}, expected ...interface{}) string
switch e := exp.(type) {
case int:
if err := assertLogEntry(e); err != "" {
- failed = append(failed, err)
+ failed = append(failed, fmt.Sprintf("missing{%s}", err))
}
case indexRange:
« no previous file with comments | « server/internal/logdog/collector/collector_test.go ('k') | server/internal/logdog/service/service.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698