Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1838773002: Clarify ShowKeyboardResultReceiver comment in ContentViewCore (Closed)

Created:
4 years, 9 months ago by Changwan Ryu
Modified:
4 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify ShowKeyboardResultReceiver comment in ContentViewCore Clarify the comment added at https://codereview.chromium.org/1809013002/ which is somewhat misleading since objects are not permanently leaked. BUG=595613 Committed: https://crrev.com/fccdae63cab073c8076d42edf15c4a8424a33a2c Cr-Commit-Position: refs/heads/master@{#383612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Changwan Ryu
4 years, 9 months ago (2016-03-28 00:46:10 UTC) #2
Ted C
lgtm
4 years, 8 months ago (2016-03-28 18:18:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838773002/1
4 years, 8 months ago (2016-03-28 23:43:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 23:48:18 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:49:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fccdae63cab073c8076d42edf15c4a8424a33a2c
Cr-Commit-Position: refs/heads/master@{#383612}

Powered by Google App Engine
This is Rietveld 408576698