Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: src/IceTargetLoweringX8632Traits.h

Issue 1838753002: Subzero: Remove IceString. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | src/IceTargetLoweringX8664.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringX8632Traits.h
diff --git a/src/IceTargetLoweringX8632Traits.h b/src/IceTargetLoweringX8632Traits.h
index 797b7318babea8d6871c8ebca9952b0d6fb0a327..12129c3b1b2030e28da892c8c2079ca44977c51f 100644
--- a/src/IceTargetLoweringX8632Traits.h
+++ b/src/IceTargetLoweringX8632Traits.h
@@ -276,7 +276,7 @@ struct TargetX8632Traits {
static const char *TargetName;
static constexpr Type WordType = IceType_i32;
- static IceString getRegName(RegNumT RegNum) {
+ static const char *getRegName(RegNumT RegNum) {
static const char *const RegNames[RegisterSet::Reg_NUM] = {
#define X(val, encode, name, base, scratch, preserved, stackptr, frameptr, \
isGPR, is64, is32, is16, is8, isXmm, is64To8, is32To8, is16To8, \
@@ -947,7 +947,8 @@ public:
public:
static SpillVariable *create(Cfg *Func, Type Ty, SizeT Index) {
- return new (Func->allocate<SpillVariable>()) SpillVariable(Ty, Index);
+ return new (Func->allocate<SpillVariable>())
+ SpillVariable(Func, Ty, Index);
}
constexpr static auto SpillVariableKind =
static_cast<OperandKind>(kVariable_Target);
@@ -959,8 +960,8 @@ public:
// Inherit dump() and emit() from Variable.
private:
- SpillVariable(Type Ty, SizeT Index)
- : Variable(SpillVariableKind, Ty, Index), LinkedTo(nullptr) {}
+ SpillVariable(const Cfg *Func, Type Ty, SizeT Index)
+ : Variable(Func, SpillVariableKind, Ty, Index), LinkedTo(nullptr) {}
Variable *LinkedTo;
};
« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | src/IceTargetLoweringX8664.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698