Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: src/IceMangling.cpp

Issue 1838753002: Subzero: Remove IceString. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceMangling.h ('k') | src/IceOperand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceMangling.cpp
diff --git a/src/IceMangling.cpp b/src/IceMangling.cpp
index 685b3d91f05def1c13d4c36485d50d7126f6d2ba..28275c15631172a9456cac7c2f35add7d8867cfe 100644
--- a/src/IceMangling.cpp
+++ b/src/IceMangling.cpp
@@ -117,7 +117,7 @@ void incrementSubstitutions(ManglerVector &OldName) {
// In this context, name mangling means to rewrite a symbol using a given
// prefix. For a C++ symbol, nest the original symbol inside the "prefix"
// namespace. For other symbols, just prepend the prefix.
-IceString mangleName(const IceString &Name) {
+std::string mangleName(const std::string &Name) {
// An already-nested name like foo::bar() gets pushed down one level, making
// it equivalent to Prefix::foo::bar().
// _ZN3foo3barExyz ==> _ZN6Prefix3foo3barExyz
@@ -129,7 +129,7 @@ IceString mangleName(const IceString &Name) {
if (!BuildDefs::dump() || GlobalContext::getFlags().getTestPrefix().empty())
return Name;
- const IceString &TestPrefix = GlobalContext::getFlags().getTestPrefix();
+ const std::string TestPrefix = GlobalContext::getFlags().getTestPrefix();
unsigned PrefixLength = TestPrefix.length();
ManglerVector NameBase(1 + Name.length());
const size_t BufLen = 30 + Name.length() + PrefixLength;
« no previous file with comments | « src/IceMangling.h ('k') | src/IceOperand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698