src/IceGlobalInits.cpp - Issue 1838753002: Subzero: Remove IceString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalInits.cpp

Issue 1838753002: Subzero: Remove IceString. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceGlobalInits.cpp

diff --git a/src/IceGlobalInits.cpp b/src/IceGlobalInits.cpp

index d2f9285a97343b6a1719eb0adca402a7304f3c5a..a21980be09f1bf4ad116a138e62c7c2df9e1b20b 100644

--- a/src/IceGlobalInits.cpp

+++ b/src/IceGlobalInits.cpp

@@ -92,7 +92,8 @@ bool FunctionDeclaration::validateIntrinsicTypeSignature(

return Signature.getReturnType() == Info->getReturnType();

}

-IceString FunctionDeclaration::getTypeSignatureError(const GlobalContext *Ctx) {

+std::string

+FunctionDeclaration::getTypeSignatureError(const GlobalContext *Ctx) {

std::string Buffer;

llvm::raw_string_ostream StrBuf(Buffer);

StrBuf << "Invalid";

« no previous file with comments | « src/IceGlobalInits.h ('k') | src/IceInst.h » ('j') | no next file with comments »