Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: src/IceELFObjectWriter.h

Issue 1838753002: Subzero: Remove IceString. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceDefs.h ('k') | src/IceELFObjectWriter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceELFObjectWriter.h
diff --git a/src/IceELFObjectWriter.h b/src/IceELFObjectWriter.h
index 94e60fdcbbfd11d00be22afe2e7639af1f7a37f7..6c979e1357f5dafb1808a61e135faa0c430c7e43 100644
--- a/src/IceELFObjectWriter.h
+++ b/src/IceELFObjectWriter.h
@@ -64,13 +64,13 @@ public:
/// RelocationKind for any relocations.
void writeDataSection(const VariableDeclarationList &Vars,
FixupKind RelocationKind,
- const IceString &SectionSuffix, bool IsPIC);
+ const std::string &SectionSuffix, bool IsPIC);
/// Copy data of a function's text section to file and note the offset of the
/// symbol's definition in the symbol table. Copy the text fixups for use
/// after all functions are written. The text buffer and fixups are extracted
/// from the Assembler object.
- void writeFunctionCode(const IceString &FuncName, bool IsInternal,
+ void writeFunctionCode(GlobalString FuncName, bool IsInternal,
Assembler *Asm);
/// Queries the GlobalContext for constant pools of the given type and writes
@@ -119,7 +119,7 @@ private:
ELFStringTableSection *StrTab;
template <typename T>
- T *createSection(const IceString &Name, Elf64_Word ShType,
+ T *createSection(const std::string &Name, Elf64_Word ShType,
Elf64_Xword ShFlags, Elf64_Xword ShAddralign,
Elf64_Xword ShEntsize);
@@ -156,8 +156,8 @@ private:
/// SectionType.
void writeDataOfType(SectionType SectionType,
const VariableDeclarationPartition &Vars,
- FixupKind RelocationKind, const IceString &SectionSuffix,
- bool IsPIC);
+ FixupKind RelocationKind,
+ const std::string &SectionSuffix, bool IsPIC);
/// Write the final relocation sections given the final symbol table. May also
/// be able to seek around the file and resolve function calls that are for
« no previous file with comments | « src/IceDefs.h ('k') | src/IceELFObjectWriter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698