src/IceBrowserCompileServer.cpp - Issue 1838753002: Subzero: Remove IceString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceBrowserCompileServer.cpp

Issue 1838753002: Subzero: Remove IceString. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceBrowserCompileServer.cpp

diff --git a/src/IceBrowserCompileServer.cpp b/src/IceBrowserCompileServer.cpp

index 5064d3021d5b10cfcb0c24b69681d6c9bbbdf045..6baf62dec1bf13b6a70bb37bc619864c42db5009 100644

--- a/src/IceBrowserCompileServer.cpp

+++ b/src/IceBrowserCompileServer.cpp

@@ -186,7 +186,7 @@ bool BrowserCompileServer::pushInputBytes(const void *Data, size_t NumBytes) {

NumBytes) != NumBytes;

}

-void BrowserCompileServer::setFatalError(const IceString &Reason) {

+void BrowserCompileServer::setFatalError(const std::string &Reason) {

HadError.store(true);

Ctx->getStrError() << Reason;

// Make sure that the QueueStreamer is not stuck by signaling an early end.

« no previous file with comments | « src/IceBrowserCompileServer.h ('k') | src/IceCfg.h » ('j') | no next file with comments »