Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/IceAssembler.h

Issue 1838753002: Subzero: Remove IceString. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Code review changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceAssemblerARM32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceAssembler.h
diff --git a/src/IceAssembler.h b/src/IceAssembler.h
index 57c949321779926ff5f28b5ea5e90f0f204a89cf..4e57a0cef74bba50ee0a9689ac045aac2bb41345 100644
--- a/src/IceAssembler.h
+++ b/src/IceAssembler.h
@@ -28,6 +28,7 @@
#include "IceDefs.h"
#include "IceFixups.h"
+#include "IceStringPool.h"
#include "IceUtils.h"
#include "llvm/Support/Allocator.h"
@@ -323,8 +324,8 @@ public:
void emitIASBytes(GlobalContext *Ctx) const;
bool getInternal() const { return IsInternal; }
void setInternal(bool Internal) { IsInternal = Internal; }
- const IceString &getFunctionName() { return FunctionName; }
- void setFunctionName(const IceString &NewName) { FunctionName = NewName; }
+ GlobalString getFunctionName() const { return FunctionName; }
+ void setFunctionName(GlobalString NewName) { FunctionName = NewName; }
intptr_t getBufferSize() const { return Buffer.size(); }
/// Roll back to a (smaller) size.
void setBufferSize(intptr_t NewSize) { Buffer.setSize(NewSize); }
@@ -347,7 +348,7 @@ private:
/// FunctionName and IsInternal are transferred from the original Cfg object,
/// since the Cfg object may be deleted by the time the assembler buffer is
/// emitted.
- IceString FunctionName = "";
+ GlobalString FunctionName;
bool IsInternal = false;
/// Preliminary indicates whether a preliminary pass is being made for
/// calculating bundle padding (Preliminary=true), versus the final pass where
« no previous file with comments | « no previous file | src/IceAssemblerARM32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698