Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183873006: Mojo: Enable RemoteMessagePipeTest on Windows. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Enable RemoteMessagePipeTest on Windows. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255295

Patch Set 1 #

Patch Set 2 : components fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -614 lines) Patch
M mojo/mojo.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/dispatcher.h View 1 2 chunks +3 lines, -12 lines 0 comments Download
M mojo/system/dispatcher.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
D mojo/system/remote_message_pipe_posix_unittest.cc View 1 chunk +0 lines, -598 lines 0 comments Download
A + mojo/system/remote_message_pipe_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/187383007/ in a trivial way.)
6 years, 9 months ago (2014-03-05 22:41:47 UTC) #1
yzshen1
LGTM Thanks!
6 years, 9 months ago (2014-03-06 00:36:57 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-06 01:30:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/183873006/20001
6 years, 9 months ago (2014-03-06 01:31:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 02:27:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=156228
6 years, 9 months ago (2014-03-06 02:27:17 UTC) #6
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-06 06:33:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/183873006/20001
6 years, 9 months ago (2014-03-06 06:33:44 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:31:59 UTC) #9
Message was sent while issue was closed. 
Change committed as 255295

Powered by Google App Engine
This is Rietveld 408576698