Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1838723002: Stop tracking trailing-space when we leave it (Closed)

Created:
4 years, 9 months ago by rhogan
Modified:
4 years, 8 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop tracking trailing-space when we leave it We were forgetting to reset our picture of trailing-space width when we re-entered a run of normal text. BUG=597193 Committed: https://crrev.com/67071ef5bb2ec084b4afdf5075c702ab0319d183 Cr-Commit-Position: refs/heads/master@{#383798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/text/whitespace/nowrap-previous-trailing-space.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/whitespace/nowrap-previous-trailing-space-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
rhogan
4 years, 9 months ago (2016-03-26 17:04:38 UTC) #3
eae
LGTM Thank you!
4 years, 8 months ago (2016-03-29 18:59:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838723002/1
4 years, 8 months ago (2016-03-29 18:59:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 20:04:55 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 20:06:25 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/67071ef5bb2ec084b4afdf5075c702ab0319d183
Cr-Commit-Position: refs/heads/master@{#383798}

Powered by Google App Engine
This is Rietveld 408576698