rewrite_to_chrome_style: improve template rewrite handling

rewrite_to_chrome_style: improve template rewrite handling

- Handles UnresolvedMemberExprs to rewrite unresolved references to
  methods in a member context.
- Use the correct SourceLocation when rewriting UnresolvedLookupExprs
  to avoid clobbering nested name specifiers.

BUG=598140, 598142
R=danakj@chromium.org

Committed: https://crrev.com/663008c70f0e5d9bfc95db70aa703432847f23ad
Cr-Commit-Position: refs/heads/master@{#383554}

[dcheng, 2016-03-26 08:45:51]

Remember how you were surprised that this works?

I guess it doesn't =D

[dcheng, 2016-03-26 21:12:27]

Description was changed from

==========
rewrite_to_chrome_style: use the right SourceLocation for UnresolvedLookupExpr

The replacement should start from the beginning of the actual name, not
the beginning of the entire UnresolvedLookupExpr.

BUG=598140
R=danakj@chromium.org
==========

to

==========
rewrite_to_chrome_style: improve template rewrite handling

- Handles UnresolvedMemberExprs to rewrite unresolved references to
  methods in a member context.
- Use the correct SourceLocation when rewriting UnresolvedLookupExprs
  to avoid clobbering nested name specifiers.

BUG=598140,598142
R=danakj@chromium.org
==========

[danakj, 2016-03-28 18:35:10]

LGTM

https://codereview.chromium.org/1838713002/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1838713002/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:799: // context,
e.g. Template<&Class::Method>.
Can you say why this not using the UnresolvedMemberRewriter? It looks
unintentional

[dcheng, 2016-03-28 19:55:08]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-03-28 19:55:09]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1838713002/#ps60001
(title: "Revert global cherry-pick")

[commit-bot: I haz the power, 2016-03-28 19:55:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838713002/60001

[commit-bot: I haz the power, 2016-03-28 20:36:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-28 20:38:20]

Description was changed from

==========
rewrite_to_chrome_style: improve template rewrite handling

- Handles UnresolvedMemberExprs to rewrite unresolved references to
  methods in a member context.
- Use the correct SourceLocation when rewriting UnresolvedLookupExprs
  to avoid clobbering nested name specifiers.

BUG=598140,598142
R=danakj@chromium.org
==========

to

==========
rewrite_to_chrome_style: improve template rewrite handling

- Handles UnresolvedMemberExprs to rewrite unresolved references to
  methods in a member context.
- Use the correct SourceLocation when rewriting UnresolvedLookupExprs
  to avoid clobbering nested name specifiers.

BUG=598140,598142
R=danakj@chromium.org

Committed: https://crrev.com/663008c70f0e5d9bfc95db70aa703432847f23ad
Cr-Commit-Position: refs/heads/master@{#383554}
==========

[commit-bot: I haz the power, 2016-03-28 20:38:21]

Patchset 4 (id:??) landed as
https://crrev.com/663008c70f0e5d9bfc95db70aa703432847f23ad
Cr-Commit-Position: refs/heads/master@{#383554}

[dcheng, 2016-03-28 21:22:44]

(forgot to send comments)

https://codereview.chromium.org/1838713002/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1838713002/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:799: // context,
e.g. Template<&Class::Method>.
On 2016/03/28 at 18:35:10, danakj wrote:
> Can you say why this not using the UnresolvedMemberRewriter? It looks
unintentional

Done.