third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h - Issue 1838683002: [DevTools] Debugger::currentCallFrames returns array instead linked list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 1838683002: [DevTools] Debugger::currentCallFrames returns array instead linked list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wrap-with-corrrect-injected-script

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

index 0a47745c1ebc1878247e090747b07d73964e39b7..2cd9534f7f7bc0c90735ba01dabf8fde336e712c 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

@@ -163,7 +163,7 @@ public:

void reset();

// Interface for V8DebuggerImpl

- SkipPauseRequest didPause(v8::Local<v8::Context>, PassOwnPtr<JavaScriptCallFrame> callFrames, v8::Local<v8::Value> exception, const protocol::Vector<String16>& hitBreakpoints, bool isPromiseRejection);

+ SkipPauseRequest didPause(v8::Local<v8::Context>, Vector<OwnPtr<JavaScriptCallFrame>> callFrames, v8::Local<v8::Value> exception, const protocol::Vector<String16>& hitBreakpoints, bool isPromiseRejection);

void didContinue();

void didParseSource(const V8DebuggerParsedScript&);

bool v8AsyncTaskEventsEnabled() const;

@@ -198,7 +198,7 @@ private:

bool assertPaused(ErrorString*);

void clearBreakDetails();

- bool isCallStackEmptyOrBlackboxed();

+ bool isCurrentCallStackEmptyOrBlackboxed();

bool isTopCallFrameBlackboxed();

bool isCallFrameWithUnknownScriptOrBlackboxed(JavaScriptCallFrame*);

@@ -225,7 +225,7 @@ private:

protocol::Frontend::Debugger* m_frontend;

v8::Isolate* m_isolate;

v8::Global<v8::Context> m_pausedContext;

- OwnPtr<JavaScriptCallFrame> m_currentCallStack;

+ Vector<OwnPtr<JavaScriptCallFrame>> m_currentCallFrames;

ScriptsMap m_scripts;

BreakpointIdToDebuggerBreakpointIdsMap m_breakpointIdToDebuggerBreakpointIds;

DebugServerBreakpointToBreakpointIdAndSourceMap m_serverBreakpoints;