Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 1838663002: Disable v8.todomvc-ignition on reference builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import shlex 5 import shlex
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from page_sets import google_pages 9 from page_sets import google_pages
10 10
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 135
136 @classmethod 136 @classmethod
137 def Name(cls): 137 def Name(cls):
138 return 'v8.todomvc' 138 return 'v8.todomvc'
139 139
140 @classmethod 140 @classmethod
141 def ShouldTearDownStateAfterEachStoryRun(cls): 141 def ShouldTearDownStateAfterEachStoryRun(cls):
142 return True 142 return True
143 143
144 144
145 @benchmark.Disabled('reference') # https://crbug.com/598096
145 class V8TodoMVCIgnition(perf_benchmark.PerfBenchmark): 146 class V8TodoMVCIgnition(perf_benchmark.PerfBenchmark):
146 """Measures V8 Execution metrics on the TodoMVC examples using ignition.""" 147 """Measures V8 Execution metrics on the TodoMVC examples using ignition."""
147 page_set = page_sets.TodoMVCPageSet 148 page_set = page_sets.TodoMVCPageSet
148 149
149 def SetExtraBrowserOptions(self, options): 150 def SetExtraBrowserOptions(self, options):
150 existing_js_flags = [] 151 existing_js_flags = []
151 for extra_arg in options.extra_browser_args: 152 for extra_arg in options.extra_browser_args:
152 if extra_arg.startswith('--js-flags='): 153 if extra_arg.startswith('--js-flags='):
153 existing_js_flags.extend(shlex.split(extra_arg[len('--js-flags='):])) 154 existing_js_flags.extend(shlex.split(extra_arg[len('--js-flags='):]))
154 options.AppendExtraBrowserArgs([ 155 options.AppendExtraBrowserArgs([
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 def Name(cls): 231 def Name(cls):
231 return 'v8.google' 232 return 'v8.google'
232 233
233 @classmethod 234 @classmethod
234 def ShouldDisable(cls, possible_browser): 235 def ShouldDisable(cls, possible_browser):
235 return cls.IsSvelte(possible_browser) # http://crbug.com/596556 236 return cls.IsSvelte(possible_browser) # http://crbug.com/596556
236 237
237 @classmethod 238 @classmethod
238 def ShouldTearDownStateAfterEachStoryRun(cls): 239 def ShouldTearDownStateAfterEachStoryRun(cls):
239 return True 240 return True
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698