Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1838653002: [ios] Use WebStateObserver to update url bar in ios_web_shell. (Closed)

Created:
4 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 8 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Use WebStateObserver to update url bar in ios_web_shell. WebStateObserver is used instead of CRWWebClient. BUG=597997 Committed: https://crrev.com/0d9f22dcfd852d8491468f8fe77cda9ed49badea Cr-Commit-Position: refs/heads/master@{#383734}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Use WebStateObserverBridge #

Patch Set 4 : Make code compile :) #

Patch Set 5 : Merged with origin/master #

Patch Set 6 : Merged with origin/master #

Patch Set 7 : Removed CANARY_VERSION #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M ios/web/shell/view_controller.mm View 1 2 3 4 5 4 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Eugene But (OOO till 7-30)
4 years, 8 months ago (2016-03-25 22:51:57 UTC) #2
Eugene But (OOO till 7-30)
Kurt?
4 years, 8 months ago (2016-03-28 23:01:26 UTC) #3
kkhorimoto
lgtm
4 years, 8 months ago (2016-03-29 01:10:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838653002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838653002/60001
4 years, 8 months ago (2016-03-29 01:10:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/10086) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-03-29 01:13:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838653002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838653002/80001
4 years, 8 months ago (2016-03-29 14:52:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/150699) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-03-29 14:53:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838653002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838653002/120001
4 years, 8 months ago (2016-03-29 15:21:08 UTC) #16
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-03-29 16:05:50 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 16:07:26 UTC) #19
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/0d9f22dcfd852d8491468f8fe77cda9ed49badea
Cr-Commit-Position: refs/heads/master@{#383734}

Powered by Google App Engine
This is Rietveld 408576698