Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 183863005: Revert 253938 "Enable icu_use_data_file_flag on Android" (Closed)

Created:
6 years, 9 months ago by Peter Kasting
Modified:
6 years, 9 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 253938 "Enable icu_use_data_file_flag on Android" May have caused crashes on Android layout test bots. > Enable icu_use_data_file_flag on Android > > 0. Roll icu to r249466 to copy Android-specific icudtl.dat > 1. Turn it in build/common.gypi by default except for android webview build. Move it inside L2 var dict and pull it up to the top level var dict to make 'Google Chrome' build on Android happy. > 2. Add an entry for icudtl.dat to chrome/chrome_android_paks.gypi so that > it's copied to assets directory for Chrome and related targets. > 3. Extract icudtl.dat from the asset and copy to DIR_ANDROID_APP_DATA and make it world-readable so that child processes (sandboxed with uid) can read it. > 4. Add icudtl.dat to MANDATORY_PAKS list in various Android build targets > > Google Chrome has #4 but in a separate CL ( https://chrome-internal-review.googlesource.com/#/c/155554/ ). That CL will land before this CL. > > TBR=avi@chromium.org > BUG=72633 > TEST=base_unittests:*Convers*, net_unittests:*IDN*, browser tests on all platforms. > > Review URL: https://codereview.chromium.org/156333002 TBR=jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -139 lines) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/android_webview/android_webview_tests.gypi View 2 chunks +0 lines, -14 lines 0 comments Download
M trunk/src/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/base/i18n/icu_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/build/android/pylib/gtest/setup.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/build/common.gypi View 5 chunks +14 lines, -10 lines 0 comments Download
M trunk/src/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellApplication.java View 1 chunk +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/chrome_android_paks.gypi View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/content/content.gyp View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/src/content/content_shell.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 4 chunks +0 lines, -16 lines 0 comments Download
M trunk/src/content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java View 7 chunks +4 lines, -29 lines 0 comments Download
M trunk/src/content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java View 1 chunk +1 line, -10 lines 0 comments Download
M trunk/src/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
6 years, 9 months ago (2014-02-28 02:18:58 UTC) #1
Peter Kasting
6 years, 9 months ago (2014-02-28 02:19:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r254020.

Powered by Google App Engine
This is Rietveld 408576698